The refactoring is almost complete:
I've just spent about five hours in total dealing with bugs I introduced into the
TDungeon level generation code while refactoring, which was mainly due to doing the refactoring offline, i.e. not within an environment where the code could compile. It has been a useful exercise, as well as removing any code that I'd be ashamed of releasing (now there's just a lot of code left that I merely
dislike), I've reaquainted myself with a lot of code that has been written for quite a while now and which I had forgotten the purpose of. The code also conforms a lot more to coding standards.
The only major source code left to refactor is
UnitDisplay.pas which, as the name suggests, is, contains the code that interfaces with the screen and the GUI-handling code. Its about 4000 lines of code. I'm on target to finish the refactor within the week or so.
Its a messy unit, full of code like this:
Procedure TFormDisplay.ListViewMonstersCompare(Sender: TObject; Item1,
Item2: TListItem; Data: Integer; var Compare: Integer);
begin
if ListViewMonsters.Items.Count = 0 then Compare := 0
else
begin
if (StrToInt(Item1.SubItems[6])) > (StrToInt(Item1.SubItems[6])) then Compare := 1
else if (StrToInt(Item1.SubItems[6])) = (StrToInt(Item1.SubItems[6])) then Compare := 0
else Compare := -1;
end;
end;
I'm not coding C, so there's no virtue in conciseness. The refactor turns that code into this (note that some of the indenting may not display properly, but the final code is indented properly):
{ Sort Routine to sort entries in the Visible Monsters display - compares two
TListItems and returns a comparison based upon TMonster.Level }
Procedure TFormDisplay.ListViewMonstersCompare(Sender: TObject; Item1,
Item2: TListItem; Data: Integer; var Compare: Integer);
var
FirstItemLevel: Integer;
SecondItemLevel: Integer;
begin
{ Logging }
hLog.Add('{now} {lNum} TFormDisplay.ListViewMonstersCompare()');
{ Default result which is that both items are equal}
Result := 0;
try
{ Make sure there are items to compare }
if ListViewMonsters.Items.Count > 0 then
begin
{ Get the monster levels from the Listview Items }
FirstItemLevel := StrToIntDef(Item1.SubItems[MONSTER_LEVEL], 0);
SecondItemLevel := StrToIntDef(Item2.SubItems[MONSTER_LEVEL], 0);
{ Compare the Monster Levels of each items }
{ First > Second }
if FirstItemLevel > SecondItemLevel then
Compare := 1
{ First <>
else if FirstItemLevel < style="font-weight: bold; color: rgb(0, 0, 102);">) then
Compare := -1;
end;
except
{ in case of error, log the Exception }
on E: Exception do hLog.AddException(E);
end;
end;
After I finish that unit, I'll have to put together the instructions for downloading and installing the various 3rd party components that I use, and then technically I'll have a source code distribution ready for when I release Kharne under the MPL.
I've just spent about five hours in total dealing with bugs I introduced into the TDungeon level generation code while refactoring, which was mainly due to doing the refactoring offline, i.e. not within an environment where the code could compile. It has been a useful exercise, as well as removing any code that I'd be ashamed of releasing (now there's just a lot of code left that I merely dislike), I've reaquainted myself with a lot of code that has been written for quite a while now and which I had forgotten the purpose of. The code also conforms a lot more to coding standards.
Pressing 'e' will bring up the inventory screen with edible items highlighted. Pressing the associated letter for an item will eat it, just like if you drag the item to the eat icon.
Pressing the key associated with the inventory slot now displays a detailed description of the item (the same information as was presented previously via the mouseover):
I've also implemented multidrop (accesible by pressing d):
Here I selected three items to drop by pressing their associated keys. Pressing ENTER then drops all the items:
I'm also going to implement similar type of funationality for eating food ('e'), reading scrolls ('r') and drinking potions ('q'), as well as for wearing and removing jewellery, weapons and armour.
The next step is to select gender:
Then racr:
And then class:
Currently the final screen is background:
I've decide to remove, for the time being, what was previously the 'full' character creation method. Pressing ESC on the background screen saves the character and starts the game as before:
There are quite a few things I could tidy up in this - a final confirmation screen that shows your character and allows you to cancel, more information on the various character creation choices and what affect they have on the character being created, and so on.
In the next version sneak-attack damage will be added to both melee and ranged physical attacks carried out by the player upon unaware foes.
...where the player can see the monster but the monster cannot see the player (and thus is still asleep) This is because the player FoV is calculated using Recursive Shadowcasting, and lacking a working noise model, monsters initially use a simple implementation of Bresenham's line algorithm to calculate if they are aware of the player or not.
The mininum (default) size is 900 x 730.
